Fix navbar menus after middle-click navigation - #1141
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | c4ce38f | Commit Preview URL Branch Preview URL |
Aug 12 2026, 03:52 PM |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe desktop navigation trigger now dismisses the menu when a middle-button auxiliary click occurs on its wrapper. ChangesDesktop navigation dismissal
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1138.
What changed
Dismiss the active desktop mega menu when an auxiliary click comes from its trigger or any nested link. The existing wrapper-level dismissal state now handles middle-click in addition to ordinary click navigation.
Root cause and impact
React's
onClickdoes not run for middle-click. The clicked link retained focus, so the CSS:focus-withinrule kept that menu visible while another hovered menu opened. Handling the bubblingauxclickonce at the menu wrapper removes the stuck panel without duplicating handlers across every link.Validation
pnpm test— TypeScript and type-aware lint clean; 127 tests passed, 1 environment-gated docs smoke test skippedgit diff --checkRisk
Low. The handler only acts for middle-button auxiliary clicks inside desktop menu wrappers and reuses the current dismissal/reset behavior.
Summary by CodeRabbit